Repository navigation
Spec, OpenAPI: Define hex case for binary and fixed values (#18352) - #18433
Open
zhang-arvin wants to merge 1 commit into
Open
zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18352
The table spec and the OpenAPI spec disagreed on how
binaryandfixedvalues are written as hex strings.format/spec.mdAppendix D said "Stored as a hexadecimal string" with the lowercase example"000102ff"and no case rule, whilerest-catalog-open-api.yaml(BinaryTypeValue/FixedTypeValue) said "serialized as an uppercase hexadecimal string". Implementations already differ, and both cases can appear in existing table metadata.This change makes the rule explicit and consistent:
"000102FF") and record the reader/writer rule in the description.BinaryTypeValue/FixedTypeValuedescriptions in the OpenAPI spec, and regeneraterest-catalog-open-api.py.